Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use GetDiscriminatorValue for TPT and TPC in queries #28054

Closed
AndriySvyryd opened this issue May 18, 2022 · 0 comments · Fixed by #28070
Closed

Use GetDiscriminatorValue for TPT and TPC in queries #28054

AndriySvyryd opened this issue May 18, 2022 · 0 comments · Fixed by #28070
Assignees
@smitpatel
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
7.0.0

Comments

@AndriySvyryd
Copy link
Member

  • Make it default to .ShortName()
  • Add validation that for non-TPH all values are unique strings
@AndriySvyryd AndriySvyryd mentioned this issue May 18, 2022
Merged
@AndriySvyryd AndriySvyryd added this to the 7.0.0 milestone May 20, 2022
smitpatel added a commit that referenced this issue May 20, 2022
@smitpatel
Query: Use GetDiscriminatorValue for TPT and TPC
f2ddc94 
Add model validation when values are not unique
Resolves #28054
@smitpatel smitpatel mentioned this issue May 20, 2022
Merged
smitpatel added a commit that referenced this issue May 26, 2022
@smitpatel
Query: Use GetDiscriminatorValue for TPT and TPC
33812a5 
Add model validation when values are not unique
Resolves #28054
smitpatel added a commit that referenced this issue May 26, 2022
@smitpatel
Query: Use GetDiscriminatorValue for TPT and TPC
36fee2c 
Add model validation when values are not unique
Resolves #28054
smitpatel added a commit that referenced this issue May 26, 2022
@smitpatel
Query: Use GetDiscriminatorValue for TPT and TPC
9090252 
Add model validation when values are not unique
Resolves #28054
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label May 26, 2022
smitpatel added a commit that referenced this issue May 27, 2022
@smitpatel
Query: Use GetDiscriminatorValue for TPT and TPC
1f4e2c9 
Add model validation when values are not unique
Resolves #28054
@ghost ghost closed this as completed in #28070 May 27, 2022
ghost pushed a commit that referenced this issue May 27, 2022
@smitpatel
Query: Use GetDiscriminatorValue for TPT and TPC (#28070)
5da4122 
Add model validation when values are not unique
Resolves #28054
@ajcvickers ajcvickers modified the milestones: 7.0.0, 7.0.0-preview6 Jun 20, 2022
@ajcvickers ajcvickers modified the milestones: 7.0.0-preview6, 7.0.0 Nov 5, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Query: Use GetDiscriminatorValue for TPT and TPC dotnet/efcore
3 participants
@ajcvickers @smitpatel @AndriySvyryd