Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ITableBasedExpression and store ITableBase in annotation #28667

Closed
smitpatel opened this issue Aug 11, 2022 · 1 comment
Closed

Remove ITableBasedExpression and store ITableBase in annotation #28667

smitpatel opened this issue Aug 11, 2022 · 1 comment
Labels
closed-by-design

Comments

@smitpatel
Copy link
Contributor

Changes the implementation for #28020
@smitpatel smitpatel self-assigned this Aug 11, 2022
@smitpatel smitpatel added this to the 7.0.0 milestone Aug 11, 2022
@smitpatel
Copy link
Contributor Author

Doing this after 7.0 is breaking change.

@smitpatel smitpatel mentioned this issue Aug 11, 2022
Merged
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Aug 11, 2022
smitpatel added a commit that referenced this issue Aug 11, 2022
@smitpatel
Remove ITableBasedExpression - Use annotation instead
6da6e80 
Resolves #28667
@smitpatel smitpatel mentioned this issue Aug 11, 2022
Closed
@smitpatel smitpatel added closed-by-design and removed closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. labels Aug 11, 2022
@smitpatel smitpatel removed this from the 7.0.0 milestone Aug 11, 2022
@smitpatel smitpatel removed their assignment Aug 11, 2022
@smitpatel smitpatel closed this as not planned Won't fix, can't repro, duplicate, stale Aug 11, 2022
smitpatel added a commit that referenced this issue Aug 12, 2022
@smitpatel
Don't implement ITableBasedExpression in FromSqlExpression
7a64f27 
Circumventing #28667 in different way
@smitpatel smitpatel mentioned this issue Aug 12, 2022
Merged
smitpatel added a commit that referenced this issue Aug 13, 2022
@smitpatel
Don't implement ITableBasedExpression in FromSqlExpression
72fd665 
Circumventing #28667 in different way
ghost pushed a commit that referenced this issue Aug 13, 2022
@smitpatel
Don't implement ITableBasedExpression in FromSqlExpression (#28699)
ba92471 
Circumventing #28667 in different way
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-by-design
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ajcvickers @smitpatel