-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seeding no longer takes max batch size into account #28876
Labels
area-migrations-seeding
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
customer-reported
regression
type-bug
Milestone
Comments
Confirmed, we no longer apply the SQL Server 42-commands-per-batch limit in seeding. In 6.0, MigrationsModelDiffer.GetDataOperations has the following: var model = updateAdapter.Model.GetRelationalModel();
var commandBatches = new CommandBatchPreparer(CommandBatchPreparerDependencies)
.BatchCommands(entries, updateAdapter); In 7.0, we just have this: var commandSets = new CommandBatchPreparer(CommandBatchPreparerDependencies)
.TopologicalSort(commands); @AndriySvyryd this change was part of #27903 (here's the code). |
roji
changed the title
7.0.0-preview.7.22376.2 / SQL Server / Migration Issue: The number of row value expressions in the INSERT statement exceeds the maximum allowed number of 1000 row values
Seeding no longer takes max batch size into account
Sep 1, 2022
roji
added a commit
to roji/efcore
that referenced
this issue
Sep 1, 2022
roji
added
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
area-migrations-seeding
and removed
area-save-changes
labels
Sep 1, 2022
roji
added a commit
to roji/efcore
that referenced
this issue
Sep 1, 2022
roji
added a commit
to roji/efcore
that referenced
this issue
Sep 6, 2022
roji
added a commit
that referenced
this issue
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-migrations-seeding
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
customer-reported
regression
type-bug
Adding >1000 rows of seed data to a single entity generates a migration that fails. Should the resulting migration be splitting inserts into batches of 1000 records?:
EF Core version: 7.0.0-preview.7.22376.2
Database provider: Microsoft.EntityFrameworkCore.SqlServer
Target framework: .NET 7.0
Operating system: Windows
IDE: None (command line)
The text was updated successfully, but these errors were encountered: