-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional dependents and entity splitting #29079
Labels
area-model-building
area-query
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
Servicing-approved
type-bug
Milestone
Comments
smitpatel
added
customer-reported
needs-design
area-query
and removed
customer-reported
labels
Sep 14, 2022
This was referenced Sep 15, 2022
Note from triage: waiting for @AndriySvyryd |
AndriySvyryd
added a commit
that referenced
this issue
Oct 6, 2022
… sharing have at least one required non-shared property Fixes #29079
Note from triage: we should block this in model validation. @AndriySvyryd to prepare PR for Tactics. |
AndriySvyryd
added
the
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
label
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-model-building
area-query
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
Servicing-approved
type-bug
In entity splitting and owned dependents with table sharing,
The main fragment of dependent has to be table sharing with any fragment of principal.
Additional fragment of dependent can be table sharing with other fragments of principal.
So combined this it creates question for optional dependents where
we check for all non-principal shared non-pk properties to see if they contain any value to figure out if dependent exists, we use this check in property access too.
How do we figure out across all tables if dependent is sharing property with principal across all of its fragments?
If we somehow arrive at the complex condition for this question, it could mean that we don't remove additional split tables even though value is not used in final result because we would use them in property access to figure out if used value should be null or column value which reduces the value of entity splitting itself if we have to join all the table all the time.
The text was updated successfully, but these errors were encountered: