Json: nullable enums on entities mapped to json don't use enum-to-int converter, rather than string, like for non-nullable enums #29217
Assignees
Labels
area-json
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
Servicing-approved
type-bug
Milestone
Comments
maumar
added a commit
that referenced
this issue
Sep 28, 2022
#29214 - Json column: constructor with optional enum-parameter throws ArgumentException When producing shaper code for json nullable properties with converters we check if the converter handles null, if not we need to peek into the json value and only pass it thru converter if it's not null, and return null otherwise #29217 - Json: nullable enums on entities mapped to json don't use enum-to-int converter, rather than string, like for non-nullable enums In convention code unwrap nullable type when testing for enum properties that we then apply converter to string #29225 - Json: projecting nullable scalar produces debug.assert in SqlExpression ctor Unwrap nullable type from property before passing it as type to SqlExpression ctor Fixes #29214 Fixes #29217 Fixes #29225
maumar
added
the
closed-fixed
maumar
added a commit
that referenced
this issue
Sep 29, 2022
#29214 - Json column: constructor with optional enum-parameter throws ArgumentException When producing shaper code for json nullable properties with converters we check if the converter handles null, if not we need to peek into the json value and only pass it thru converter if it's not null, and return null otherwise #29217 - Json: nullable enums on entities mapped to json don't use enum-to-int converter, rather than string, like for non-nullable enums In convention code unwrap nullable type when testing for enum properties that we then apply converter to string #29225 - Json: projecting nullable scalar produces debug.assert in SqlExpression ctor Unwrap nullable type from property before passing it as type to SqlExpression ctor Fixes #29214 Fixes #29217 Fixes #29225
maumar
added a commit
that referenced
this issue
Sep 29, 2022
#29214 - Json column: constructor with optional enum-parameter throws ArgumentException When producing shaper code for json nullable properties with converters we check if the converter handles null, if not we need to peek into the json value and only pass it thru converter if it's not null, and return null otherwise #29217 - Json: nullable enums on entities mapped to json don't use enum-to-int converter, rather than string, like for non-nullable enums In convention code unwrap nullable type when testing for enum properties that we then apply converter to string #29225 - Json: projecting nullable scalar produces debug.assert in SqlExpression ctor Unwrap nullable type from property before passing it as type to SqlExpression ctor Fixes #29214 Fixes #29217 Fixes #29225
maumar
added a commit
that referenced
this issue
Oct 1, 2022
#29214 - Json column: constructor with optional enum-parameter throws ArgumentException When producing shaper code for json nullable properties with converters we check if the converter handles null, if not we need to peek into the json value and only pass it thru converter if it's not null, and return null otherwise #29217 - Json: nullable enums on entities mapped to json don't use enum-to-int converter, rather than string, like for non-nullable enums In convention code unwrap nullable type when testing for enum properties that we then apply converter to string #29225 - Json: projecting nullable scalar produces debug.assert in SqlExpression ctor Unwrap nullable type from property before passing it as type to SqlExpression ctor #29219 - Json: error when trying to materialize json entity with nullable property that is missing in the json string - should materialize the property as null instead Modify ExtractJsonProperty method so that it used TryGetProperty when trying to extract nullable properties. Fixes #29214 Fixes #29217 Fixes #29225 Fixes #29219
maumar
added a commit
that referenced
this issue
Oct 1, 2022
#29214 - Json column: constructor with optional enum-parameter throws ArgumentException When producing shaper code for json nullable properties with converters we check if the converter handles null, if not we need to peek into the json value and only pass it thru converter if it's not null, and return null otherwise #29217 - Json: nullable enums on entities mapped to json don't use enum-to-int converter, rather than string, like for non-nullable enums In convention code unwrap nullable type when testing for enum properties that we then apply converter to string #29225 - Json: projecting nullable scalar produces debug.assert in SqlExpression ctor Unwrap nullable type from property before passing it as type to SqlExpression ctor #29219 - Json: error when trying to materialize json entity with nullable property that is missing in the json string - should materialize the property as null instead Modify ExtractJsonProperty method so that it used TryGetProperty when trying to extract nullable properties. Fixes #29214 Fixes #29217 Fixes #29225 Fixes #29219
maumar
added a commit
that referenced
this issue
Oct 3, 2022
#29214 - Json column: constructor with optional enum-parameter throws ArgumentException When producing shaper code for json nullable properties with converters we check if the converter handles null, if not we need to peek into the json value and only pass it thru converter if it's not null, and return null otherwise #29217 - Json: nullable enums on entities mapped to json don't use enum-to-int converter, rather than string, like for non-nullable enums In convention code unwrap nullable type when testing for enum properties that we then apply converter to string #29225 - Json: projecting nullable scalar produces debug.assert in SqlExpression ctor Unwrap nullable type from property before passing it as type to SqlExpression ctor #29219 - Json: error when trying to materialize json entity with nullable property that is missing in the json string - should materialize the property as null instead Modify ExtractJsonProperty method so that it used TryGetProperty when trying to extract nullable properties. Fixes #29214 Fixes #29217 Fixes #29225 Fixes #29219
maumar
added a commit
that referenced
this issue
Oct 4, 2022
#29214 - Json column: constructor with optional enum-parameter throws ArgumentException When producing shaper code for json nullable properties with converters we check if the converter handles null, if not we need to peek into the json value and only pass it thru converter if it's not null, and return null otherwise #29217 - Json: nullable enums on entities mapped to json don't use enum-to-int converter, rather than string, like for non-nullable enums In convention code unwrap nullable type when testing for enum properties that we then apply converter to string #29225 - Json: projecting nullable scalar produces debug.assert in SqlExpression ctor Unwrap nullable type from property before passing it as type to SqlExpression ctor #29219 - Json: error when trying to materialize json entity with nullable property that is missing in the json string - should materialize the property as null instead Modify ExtractJsonProperty method so that it used TryGetProperty when trying to extract nullable properties. Fixes #29214 Fixes #29217 Fixes #29225 Fixes #29219
|
fixed in d4c22b2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
in RelationalMapToJsonConvention.ProcessModelFinalizing we are looking for all properties whose clr type IsEnum is true. However, this returns false for the nullable enums. We should take that case into account also
The text was updated successfully, but these errors were encountered: