Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in XML documentation in EntityFrameworkQueryableExtensions #29978

Closed
nbarbettini opened this issue Jan 4, 2023 · 1 comment
Closed

Typo in XML documentation in EntityFrameworkQueryableExtensions #29978

nbarbettini opened this issue Jan 4, 2023 · 1 comment
Assignees
@roji
Labels
area-docs closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-bug
Milestone
8.0.0

Comments

@nbarbettini
Copy link
Member

There is a grammatical error in this code doc: https://github.com/dotnet/efcore/blob/main/src/EFCore/Extensions/EntityFrameworkQueryableExtensions.cs#L25

I believe it should read This string may not be suitable for direct execution and is intended only for use in debugging.
nbarbettini added a commit to nbarbettini/efcore that referenced this issue Jan 4, 2023
@nbarbettini
Fix grammar in XML doc for ToQueryString
c188bb1 
Fixes dotnet#29978
@roji roji closed this as completed in 36e9a9e Jan 5, 2023
@roji
Copy link
Member

roji commented Jan 5, 2023

@nbarbettini thanks for submitting #29979 to fix this. In general, you can always just directly submit a PR fixing minor doc issues without needing to file an issue or describing your proposed change.

@roji roji added the area-docs label Jan 5, 2023
@roji roji added this to the 8.0.0 milestone Jan 5, 2023
@roji roji self-assigned this Jan 5, 2023
@ajcvickers ajcvickers added closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported labels Jan 12, 2023
@ajcvickers ajcvickers modified the milestones: 8.0.0, 8.0.0-preview1 Jan 29, 2023
@roji roji mentioned this issue Feb 12, 2023
Closed
@ajcvickers ajcvickers modified the milestones: 8.0.0-preview1, 8.0.0 Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
area-docs closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-bug
Projects
None yet
Milestone
8.0.0
Development

No branches or pull requests
3 participants
@ajcvickers @roji @nbarbettini