Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary breaking changes in NavigationEntry in EF Core 8.0 #31104

Closed
kevinchalet opened this issue Jun 19, 2023 · 0 comments · Fixed by #31141
Closed

Binary breaking changes in NavigationEntry in EF Core 8.0 #31104

kevinchalet opened this issue Jun 19, 2023 · 0 comments · Fixed by #31141
Labels
area-change-tracking closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-bug
Milestone

Comments

@kevinchalet
Copy link

EF Core 7.0 (and earlier) has the following NavigationEntry.LoadAsync(...) API:

public abstract Task LoadAsync(CancellationToken cancellationToken = default);

This API was removed in EF Core 8.0 (without being obsoleted first, BTW...) and replaced by:

public abstract Task LoadAsync(LoadOptions options = LoadOptions.None, CancellationToken cancellationToken = default);

The signature has changed in a breaking way (an optional parameter has been added), which causes MemberMissingExceptions when referencing EF Core 8.0 in a project that has dependencies built against EF Core 7.0 (or earlier).

System.MissingMethodException : 'Method not found: 'System.Threading.Tasks.Task Microsoft.EntityFrameworkCore.ChangeTracking.NavigationEntry.LoadAsync(System.Threading.CancellationToken)'.'

Since it was requested by @roji, I attached a simple repro.

(it's very likely other APIs - like Load - have the same issue)

NavigationEntryBreakingChange.zip

@kevinchalet kevinchalet mentioned this issue Jun 19, 2023
52 tasks
@ajcvickers ajcvickers added this to the 8.0.0 milestone Jun 26, 2023
@ajcvickers ajcvickers self-assigned this Jun 26, 2023
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jun 26, 2023
@ajcvickers ajcvickers modified the milestones: 8.0.0, 8.0.0-preview7 Jun 27, 2023
@ajcvickers ajcvickers modified the milestones: 8.0.0-preview7, 8.0.0 Nov 14, 2023
@ajcvickers ajcvickers removed their assignment Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-change-tracking closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants