Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nav expansion visitor does not visit the non-lambda arguments (Skip, Take, ElementAt) #32312

Closed
roji opened this issue Nov 15, 2023 · 0 comments
Closed

Nav expansion visitor does not visit the non-lambda arguments (Skip, Take, ElementAt) #32312

roji opened this issue Nov 15, 2023 · 0 comments
Assignees
@maumar
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. Servicing-approved type-bug
Milestone
8.0.2

Comments

@roji
Copy link
Member

roji commented Nov 15, 2023

This tracks having nav expansion properly visit non-lambda arguments. It is the same as #32217, but tracks all operators other than Contains; this is because we want to have separate quirks for the 8.0.x patch, to allow users to keep visiting Contains (clear, known regression), but avoid visiting other operators in case that causes a problem.
@roji roji mentioned this issue Nov 15, 2023
Closed
maumar added a commit that referenced this issue Nov 16, 2023
@maumar
Fix to #32217 - Nav expansion visitor does not visit the Contains ite…
c615d12 
…m argument (and possibly other non-lambda arguments)

This was always a problem but was uncovered by change in how we process Contains. We were going through the full process of nav expansion on the argument (only on the source), which could lead to untranslatable expression tree in some cases.

Fixes #32217
Fixes #32312
@maumar maumar mentioned this issue Nov 16, 2023
Merged
maumar added a commit that referenced this issue Nov 16, 2023
@maumar
Fix to #32217 - Nav expansion visitor does not visit the Contains ite…
db2bae3 
…m argument (and possibly other non-lambda arguments)

This was always a problem but was uncovered by change in how we process Contains. We were going through the full process of nav expansion on the argument (only on the source), which could lead to untranslatable expression tree in some cases.

Fixes #32217
Fixes #32312
maumar added a commit that referenced this issue Nov 16, 2023
@maumar
Fix to #32217 - Nav expansion visitor does not visit the Contains ite…
a97d3c5 
…m argument (and possibly other non-lambda arguments)

This was always a problem but was uncovered by change in how we process Contains. We were going through the full process of nav expansion on the argument (only on the source), which could lead to untranslatable expression tree in some cases.

Fixes #32217
Fixes #32312
@ajcvickers ajcvickers added this to the 8.0.2 milestone Nov 17, 2023
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maumar maumar

Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. Servicing-approved type-bug
Projects
None yet
Milestone
8.0.2
Development

No branches or pull requests
3 participants
@ajcvickers @maumar @roji