Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OwnedNavigationBuilder.HasIndex lacks overload with name argument #33739

Closed
achnologia opened this issue May 17, 2024 · 0 comments · Fixed by #34427
Closed

OwnedNavigationBuilder.HasIndex lacks overload with name argument #33739

achnologia opened this issue May 17, 2024 · 0 comments · Fixed by #34427
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-enhancement
Milestone

Comments

@achnologia
Copy link

achnologia commented May 17, 2024

Hello everyone!

I have a need to remap a bunch of fields into an owned entity. Some of the fields have multiple indexes on them.
With EntityTypeBuilder it works like a charm after implementation of #21089.

But I found out that OwnedNavigationBuilder lacks HasIndex method overload with name argument, tho they're using the same InternalEntityTypeBuilder under the hood.
This leads to the same problem that latest index overrides every index before it.

I looked through PR: #21115 and didn't find any mentions of owned entities.

I wonder if there's any reason it was not implemented or just forgotten about?
If it duplicates already existing question, please point to it, I wasn't able to find anything related on my own

EF Core version: 8.0.2
Database provider: Npgsql 8.0.2
Target framework: .NET 8.0

@AndriySvyryd AndriySvyryd added this to the 9.0.0 milestone May 17, 2024
AndriySvyryd added a commit that referenced this issue Aug 13, 2024
Add IConventionEntityTypeBuilder API for UseSqlReturningClause and UseSqlOutputClause

Fixes #33739
Fixes #33287
@AndriySvyryd AndriySvyryd added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Aug 13, 2024
@AndriySvyryd AndriySvyryd removed their assignment Aug 13, 2024
AndriySvyryd added a commit that referenced this issue Aug 13, 2024
Add IConventionEntityTypeBuilder API for UseSqlReturningClause and UseSqlOutputClause

Fixes #33739
Fixes #33287
AndriySvyryd added a commit that referenced this issue Aug 13, 2024
Add IConventionEntityTypeBuilder API for UseSqlReturningClause and UseSqlOutputClause

Fixes #33739
Fixes #33287
AndriySvyryd added a commit that referenced this issue Aug 14, 2024
Add IConventionEntityTypeBuilder API for UseSqlReturningClause and UseSqlOutputClause

Fixes #33739
Fixes #33287
AndriySvyryd added a commit that referenced this issue Aug 14, 2024
Add IConventionEntityTypeBuilder API for UseSqlReturningClause and UseSqlOutputClause

Fixes #33739
Fixes #33287
AndriySvyryd added a commit that referenced this issue Aug 14, 2024
Add IConventionEntityTypeBuilder API for UseSqlReturningClause and UseSqlOutputClause

Fixes #33739
Fixes #33287
@ajcvickers ajcvickers modified the milestones: 9.0.0, 9.0.0-rc1 Aug 21, 2024
@roji roji modified the milestones: 9.0.0-rc1, 9.0.0 Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants