-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cosmos: handle fake LeftJoins in query tree #33969
Comments
And some test cleanup Closes dotnet#33969
These turned out to be non-fake LeftJoins, since a non-owned entity (Planet) is accessed in the query above. Will introduce a specialized translation failure message for this case, and scrub the tests hitting this (see #34066). |
And some test cleanup Closes dotnet#33969
And some test cleanup Closes dotnet#33969
@roji Should this be closed-fixed and in a release, or closed-no-further-action and then closed as not-planned? |
Thanks for going over these @ajcvickers. This ended up being an error message tweak and a test cleanup, am placing in the 9.0 milestone as closed-fixed. |
Our preprocessing (nav expansion) produces LeftJoin nodes for owned entity collection, such as in the following case:
Of course, in Cosmos (and in relational JSON), p.Orders doesn't represent a join at all; so we need to ignore it, reverse-engineering the original query so that this can be translated.
Long-term, we should get rid of these nodes altogether by removing nav expansion as a preprocessing step (#32957).
The text was updated successfully, but these errors were encountered: