-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update scaffolding to use ScaffoldingTypeMapper #5410
Comments
When this is done, verify that decimal and numeric columns have scale/precision included in column type |
This work was also mentioned as part of #1671 |
The type for decimal properties should always be specified, even if same as default, due to #6944 |
@lajones Can you elaborate on why this is flagged as a breaking change? |
@ajcvickers This is part of the overall type mapping work. Though I haven't mapped out the exact API on how that will work yet, I don't think we'll manage to get through all of that without changing any of the type-mapping API. I don't know that it will specifically affect the |
@ajcvickers The latter. I'm saying #7434 may affect the APIs on |
Moving this out of preview2 since it doesn't need to be done. |
Poaching this as it is needed for #7004 |
This follows the changes made for #4425 which provides more information from the type mapper to scaffolding on what to scaffold for a given property. However, the implementation assumes that IsUnicode has been implemented and so this cannot be done until that issue is fixed--see #3420.
The text was updated successfully, but these errors were encountered: