Infrastructure: Trace when query is done. This is needed in order to get SelectRows statistics.

[fitzchak]

In order to get the SelectRows from SqlStatistics we need to add this trace statement, since "System.Data.SqlClient.WriteCommandAfter" tracing is not enough, as this is before the reader is reading the results.
This let us in Entity Framework Profiler report the results for the query.

[fitzchak]

cc @anpete

[fitzchak]

Can this get into next release of v1?

[ajcvickers]

Marking for re-triage to consider putting it in patch release.

[ajcvickers]

@fitzchak We discussed this but unfortunately we don't think it meets the bar for a patch release, especially because it contains a binary-compat breaking change. Is there any way you can work around the issue you have without taking the change?

[fitzchak]

@ajcvickers We cannot work around this.
What is the binary compat breaking change? Isn't it just adding more logs?

[ajcvickers]

@fitzchak The PR changes the signature for the RelationalDataReader constructor. We might be able to make the change in a non-breaking way, but to justify it going into a patch release we will need some details as to exactly what is not working so we can get approval.

[ajcvickers]

EF Team Triage: Closing this issue as the requested additional details have not been provided and we have been unable to reproduce it.

BTW this is a canned response and may have info or details that do not directly apply to this particular issue. While we'd like to spend the time to uniquely address every incoming issue, we get a lot traffic on the EF projects and that is not practical. To ensure we maximize the time we have to work on fixing bugs, implementing new features, etc. we use canned responses for common triage decisions.

[fitzchak]

Hi,
We need this in order to show Row Count in EntityFrameworkProfiler: http://issues.hibernatingrhinos.com/issue/UberProf-365
Can you re-open?

[divega]

@fitzchak to be clear, your PR made it into 2.0.0-preview1. It just did not make into a patch for the 1.x versions (that is what the last few comments are about). Are you getting many customer requests for this functionality in 1.x versions?

[fitzchak]

@divega Hi, yes. We have many customer requests to use the profiler with the current version of EntityFrameworkCore. The profiler is working well, but do not show the row count and duration for the statements (see attachment image) and we get many requests to fix this. This PR should fix this.