Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: OrderBy_correlated_subquery_lol2 seems to be a very slow test #7864

Closed
ajcvickers opened this issue Mar 13, 2017 · 4 comments
Closed

Query: OrderBy_correlated_subquery_lol2 seems to be a very slow test #7864

ajcvickers opened this issue Mar 13, 2017 · 4 comments
Assignees
@maumar
Labels
area-perf area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
2.0.0

Comments

@ajcvickers
Copy link
Contributor

The OrderBy_correlated_subquery_lol2 test seems to run slowly on SQLite, In-memory, and SQL Server. We should check if there is a way to make it faster while still testing what it needs to test.

  • QuerySqliteTest.OrderBy_correlated_subquery_lol2: 145 seconds
  • QueryInMemoryTest.OrderBy_correlated_subquery_lol2: 86 seconds
  • RowNumberPagingTest.OrderBy_correlated_subquery_lol2: 82 seconds
  • QuerySqlServerTest.OrderBy_correlated_subquery_lol2: 81 seconds

Lol.
@ajcvickers ajcvickers added this to the 2.0.0 milestone Mar 13, 2017
@ajcvickers
Copy link
Contributor Author

@maumar Can you make this your second priority, after the 1.1.0 to 1.1.1 regressions? We can discuss again if there are no easy wins here.

@ajcvickers
Copy link
Contributor Author

Also related to #7837.

maumar added a commit that referenced this issue Mar 13, 2017
@maumar
Fix to #7864 - OrderBy_correlated_subquery_lol2 seems to be a very sl…
700cc88 
…ow test

Problem was in the in-memory portion of the test. We would execute 830 subqueries and that took the vast majority of the time. Fix is to introduce additional predicate, cutting the number of subqueries down to 4.
maumar added a commit that referenced this issue Mar 13, 2017
@maumar
Fix to #7864 - OrderBy_correlated_subquery_lol2 seems to be a very sl…
c402d73 
…ow test

Problem was in the in-memory portion of the test. We would execute 830 subqueries and that took the vast majority of the time. Fix is to introduce additional predicate, cutting the number of subqueries down to 4.
@maumar
Copy link
Contributor

maumar commented Mar 13, 2017

Fixed in c402d73

@maumar maumar closed this as completed Mar 13, 2017
@maumar maumar added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Mar 13, 2017
azabluda added a commit to azabluda/InfoCarrier.Core that referenced this issue Apr 28, 2017
@azabluda
Just checked the slow 'OrderBy_correlated_subquery_lol2' test again, …
ab9e479 
…it runs 40+ sec not because of EF but on the LINQ-to-Objects phase.

LOL indeed.
Unskip the test.
See also dotnet/efcore#7864
@ajcvickers ajcvickers changed the title OrderBy_correlated_subquery_lol2 seems to be a very slow test Query: OrderBy_correlated_subquery_lol2 seems to be a very slow test May 9, 2017
@smitpatel
Copy link
Contributor

@divega - This does not seem to be enhancement. It was just test which used to pull a lot of data. We trimmed down the size of result to speed up. No product code changes.

@ajcvickers ajcvickers modified the milestones: 2.0.0-preview1, 2.0.0 Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maumar maumar

Labels
area-perf area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
4 participants
@divega @ajcvickers @smitpatel @maumar