-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve binding of RelationalTypeMapping objects to model #8625
Comments
If we do this, then we will do it as part of the read-only model--see #8258. |
Based on discussion in #11738, we should likely remove the fallback code. |
Note that this item and #14433 are actually different. Both items are about the type mapping always being available on the IProperty. However, for #14433 we will keep using the current solution, which is running a ModelBuiltConvention, but cleanup code that assumes this might not have run. This issue is about a more efficient and more lazy mechanism to do this that would not require a full model traversal. |
This can be accomplished with #22031 |
Fixed in bca8fa5 |
In #8605 RelationalTypeMapping objects were bound to properties using conventions. However, conventions may not be the best thing to do here, since sometimes conventions aren't used when building the model. This is a problem because the runtime absolutely needs to be able to get RelationalTypeMapping objects for any property. This means that currently there is a fallback mechanism that will try to find a mapping that has not been set. If we could instead ensure that a property always has a mapping. then it would simplify our code. This might be done as part of #8258.
(See also #8624.)
The text was updated successfully, but these errors were encountered: