Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve binding of RelationalTypeMapping objects to model #8625

Closed
ajcvickers opened this issue May 27, 2017 · 5 comments
Closed

Improve binding of RelationalTypeMapping objects to model #8625

ajcvickers opened this issue May 27, 2017 · 5 comments
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone

Comments

@ajcvickers
Copy link
Member

In #8605 RelationalTypeMapping objects were bound to properties using conventions. However, conventions may not be the best thing to do here, since sometimes conventions aren't used when building the model. This is a problem because the runtime absolutely needs to be able to get RelationalTypeMapping objects for any property. This means that currently there is a fallback mechanism that will try to find a mapping that has not been set. If we could instead ensure that a property always has a mapping. then it would simplify our code. This might be done as part of #8258.

(See also #8624.)

@ajcvickers
Copy link
Member Author

If we do this, then we will do it as part of the read-only model--see #8258.

@ajcvickers
Copy link
Member Author

Based on discussion in #11738, we should likely remove the fallback code.

@ajcvickers
Copy link
Member Author

Note that this item and #14433 are actually different. Both items are about the type mapping always being available on the IProperty. However, for #14433 we will keep using the current solution, which is running a ModelBuiltConvention, but cleanup code that assumes this might not have run. This issue is about a more efficient and more lazy mechanism to do this that would not require a full model traversal.

@ajcvickers ajcvickers removed this from the 3.0.0 milestone Jan 24, 2019
@ajcvickers ajcvickers added this to the Backlog milestone Jan 24, 2019
@AndriySvyryd
Copy link
Member

AndriySvyryd commented Aug 22, 2019

This can be accomplished with #22031

@AndriySvyryd AndriySvyryd removed their assignment Oct 20, 2022
@AndriySvyryd AndriySvyryd added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Oct 20, 2022
@AndriySvyryd AndriySvyryd modified the milestones: Backlog, 6.0.0 Oct 20, 2022
@AndriySvyryd
Copy link
Member

Fixed in bca8fa5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Development

No branches or pull requests

2 participants