Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure TypeMapping is always present on IProperty #14433

Closed
smitpatel opened this issue Jan 15, 2019 · 1 comment · Fixed by #16178
Closed

Ensure TypeMapping is always present on IProperty #14433

smitpatel opened this issue Jan 15, 2019 · 1 comment · Fixed by #16178
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Milestone
3.0.0

Comments

@smitpatel
Copy link
Contributor

For #13192, we need type mapping for every scalar in SQL tree so that we can propagate appropriately and apply inference. The basic building block for it, is columns which corresponds to IProperty. It would be useful to have TypeMapping always present on IProperty.
@AndriySvyryd
Copy link
Member

Can be implemented with default value conventions #9329

@ajcvickers ajcvickers added this to the 3.0.0 milestone Jan 16, 2019
@ajcvickers ajcvickers self-assigned this Jan 16, 2019
@smitpatel smitpatel changed the title Ensure: TypeMapping is always present on IProperty Ensure TypeMapping is always present on IProperty Jan 23, 2019
@ajcvickers ajcvickers mentioned this issue Jan 24, 2019
Closed
ajcvickers added a commit that referenced this issue Jun 20, 2019
@ajcvickers
Be explicit about type mappings being available on the finalized model
ed9b324 
Part of #15663
Fixes #14433

The `GetTypeMapping` and `GetRelationalTypeMapping` methods will throw if there isn't a type mapping annotated on the model. Model finalization ensures that this is true.

Find methods still exist for cases where they need to be called before the model is finalized, and also so as not to break when not needed. However, see #16177
@ajcvickers ajcvickers mentioned this issue Jun 20, 2019
Merged
ajcvickers added a commit that referenced this issue Jun 20, 2019
@ajcvickers
Be explicit about type mappings being available on the finalized model
dfe3110 
Part of #15663
Fixes #14433

The `GetTypeMapping` and `GetRelationalTypeMapping` methods will throw if there isn't a type mapping annotated on the model. Model finalization ensures that this is true.

Find methods still exist for cases where they need to be called before the model is finalized, and also so as not to break when not needed. However, see #16177
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jun 20, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview7 Jul 2, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview7, 3.0.0 Nov 11, 2019
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Be explicit about type mappings being available on the finalized model dotnet/efcore
3 participants
@ajcvickers @smitpatel @AndriySvyryd