Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constrain FindMapping and FindRelationalMapping to mutable/convention properties #16177

Closed
ajcvickers opened this issue Jun 20, 2019 · 1 comment
Closed

Constrain FindMapping and FindRelationalMapping to mutable/convention properties #16177

ajcvickers opened this issue Jun 20, 2019 · 1 comment
Labels
breaking-change closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed.

Comments

@ajcvickers
Copy link
Contributor

Since once the model is finalized the mapping is always present.

However, other API surface will also need to be changed because these methods are called from places where we have already lost information as to the type of property interface being used.
ajcvickers added a commit that referenced this issue Jun 20, 2019
@ajcvickers
Be explicit about type mappings being available on the finalized model
ed9b324 
Part of #15663
Fixes #14433

The `GetTypeMapping` and `GetRelationalTypeMapping` methods will throw if there isn't a type mapping annotated on the model. Model finalization ensures that this is true.

Find methods still exist for cases where they need to be called before the model is finalized, and also so as not to break when not needed. However, see #16177
@ajcvickers ajcvickers mentioned this issue Jun 20, 2019
Merged
ajcvickers added a commit that referenced this issue Jun 20, 2019
@ajcvickers
Be explicit about type mappings being available on the finalized model
dfe3110 
Part of #15663
Fixes #14433

The `GetTypeMapping` and `GetRelationalTypeMapping` methods will throw if there isn't a type mapping annotated on the model. Model finalization ensures that this is true.

Find methods still exist for cases where they need to be called before the model is finalized, and also so as not to break when not needed. However, see #16177
@ajcvickers
Copy link
Contributor Author

Triage: value not high enough.

@ajcvickers ajcvickers added the closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed. label Mar 10, 2022
@ajcvickers ajcvickers reopened this Oct 16, 2022
@ajcvickers ajcvickers closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ajcvickers