Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Output parameter in FromSql is always null #9309

Closed
smitpatel opened this issue Jul 31, 2017 · 3 comments
Closed

Query: Output parameter in FromSql is always null #9309

smitpatel opened this issue Jul 31, 2017 · 3 comments
Assignees
@smitpatel
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
2.0.3

Comments

@smitpatel
Copy link
Contributor

smitpatel commented Jul 31, 2017 •
edited
Loading

This issue is to track porting of #9277 for patch.

Impact: Using FromSql with out parameters on SqlServer will never return value of out parameter. All such scenarios are broken.
Work-around:None
@divega divega added this to the 2.0.1 milestone Aug 2, 2017
@divega divega added the type-bug label Aug 2, 2017
@smitpatel smitpatel changed the title Query: Output parameter in FromSql is always returns null Query: Output parameter in FromSql/ExecuteSqlCommand is always returns null Aug 15, 2017
@smitpatel smitpatel mentioned this issue Sep 12, 2017
Merged
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Sep 12, 2017
@smitpatel
Copy link
Contributor Author

Impact: Using FromSql with out parameters on SqlServer will never return value of out parameter. All such scenarios are broken.
Risk: Low. The fix was to clear the parameters after reader is disposed. Hence the code to clear parameter collection was moved to appropriate place and it is still part of pipeline in all scenarios.

@Eilon
Copy link
Member

Eilon commented Sep 15, 2017

This patch bug is approved for the 2.0.x patch. Please send a PR to the feature/2.0.1 branch and get it reviewed and merged. When we have the rel/2.0.1 branches ready please port the commit to that branch.

dougbu added a commit to dougbu/EntityFramework_7048 that referenced this issue Oct 18, 2017
@dougbu
Add dotnet/efcore#9277 / dotnet/efcore#9309 scenario
7997547
dougbu added a commit to dougbu/EntityFramework_7048 that referenced this issue Oct 18, 2017
@dougbu
Switch to SQL Server and add dotnet/efcore#9277 / dotnet/efcore#9309 …
e4a3f96 
…scenarios
@smitpatel smitpatel changed the title Query: Output parameter in FromSql/ExecuteSqlCommand is always returns null Query: Output parameter in FromSql is always returns null Oct 18, 2017
@Eilon
Copy link
Member

Eilon commented Oct 23, 2017

Hi, we have a public test feed that you can use to try out the ASP.NET/EF Core 2.0.3 patch!

To try out the pre-release patch, please refer to the following guide:

We are looking for feedback on this patch. We'd like to know if you have any issues with this patch by updating your apps and libraries to the latest packages and seeing if it fixes the issues you've had, or if it introduces any new issues. If you have any issues or questions, please reply on this issue to let us know as soon as possible.

Thanks,
Eilon

@divega divega changed the title Query: Output parameter in FromSql is always returns null Query: Output parameter in FromSql is always null Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
2.0.3
Development

No branches or pull requests
4 participants
@Eilon @divega @ajcvickers @smitpatel