Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmarks: Run with SQLite provider #9681

Closed
bricelam opened this issue Sep 1, 2017 · 1 comment
Closed

Benchmarks: Run with SQLite provider #9681

bricelam opened this issue Sep 1, 2017 · 1 comment
Assignees
@smitpatel
Labels
area-benchmarks area-perf area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
2.1.0

Comments

@bricelam
Copy link
Contributor

bricelam commented Sep 1, 2017 •
edited
Loading

This will help us detect any regressions in both Microsoft.EntityFrameworkCore.Sqlite and Microsoft.Data.Sqlite.

(For both 2.0.0 and dev)
@smitpatel
Copy link
Contributor

See #9177 (comment)

It was ask from provider writers to generate a set of test (like our specs tests), so that any provider can run benchmark tests against those.

We can either do the simplest here and copy code to run against SQLite or
We can refactor the code.

@ajcvickers ajcvickers added this to the 2.1.0 milestone Sep 6, 2017
@ajcvickers ajcvickers modified the milestones: 2.1.0-preview1, 2.1.0 Jan 17, 2018
smitpatel added a commit that referenced this issue Feb 27, 2018
@smitpatel
Benchmarks: Refactor benchmarks to be provider agnostic
5dd16d4 
Run benchmarks for Sqlite provider

Resolves #9681
@smitpatel smitpatel mentioned this issue Feb 27, 2018
Merged
smitpatel added a commit that referenced this issue Feb 28, 2018
@smitpatel
Benchmarks: Refactor benchmarks to be provider agnostic
09f5704 
Run benchmarks for Sqlite provider

Resolves #9681
smitpatel added a commit that referenced this issue Feb 28, 2018
@smitpatel
Benchmarks: Refactor benchmarks to be provider agnostic
0ab0729 
Run benchmarks for Sqlite provider

Resolves #9681
@divega divega added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Apr 7, 2018
@ajcvickers ajcvickers modified the milestones: 2.1.0-preview2, 2.1.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
area-benchmarks area-perf area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
5 participants
@bricelam @divega @ajcvickers @smitpatel @roji