Fix #9956 - Add support for private and protected methods in DbFunctions #10040
Conversation
pmiddleton
changed the title
| while(contextType != typeof(DbContext)) | ||
| { | ||
| var functions = contextType.GetMethods(BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance | ||
| | BindingFlags.Static | BindingFlags.DeclaredOnly) |
There was a problem hiding this comment.
BindingFlags.DeclaredOnly to search only the methods declared on the Type, not methods that were simply inherited.
I believe this should be different. When working with multi-context scenarios (using different contexts for read/write), user may want to just put method on common base instead of the exact context instance.
Also FlattenHierarchy should be there to find static members from base classes.
There was a problem hiding this comment.
The while loop will walk up the inheritance chain pulling methods until it gets to DbContext.
We need to do this because base class private methods are not returned when methods are pulled from derived types.
FlattenHierarchy is disabled to prevent duplicate static methods from being returned during the inheritance walk.
There was a problem hiding this comment.
Ah. didn't realize the loop.
|
@pmiddleton - If you get some time then can you rebase this on latest dev? |
|
Merged via 843929d |
Resolves #9956
Adds support for private, protected, internal, and protected internal