Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle value generation when value conversion is being used #11479

Merged
merged 1 commit into from
Mar 30, 2018

Conversation

ajcvickers
Copy link
Member

Fixes #11010

Approach is:

  • Throw by default if a converter is associated with a property that will use value generation
  • However, a value generator to use can be specified:
    • On the property
    • On the type mapping
    • On a converter
  • A client-side generator is added to the Guid converters so that Guid key scenarios still work

@ajcvickers
Copy link
Member Author

/cc @divega FYI

@divega
Copy link
Contributor

divega commented Mar 30, 2018

@ajcvickers are there still further improvements (like the ones we discussed yesterday) that would make sense to track in an issue, or do you prefer to wait for feedback?

@ajcvickers
Copy link
Member Author

@divega Probably worth having an issue to check for other "safe" generators we could add, but would rather wait until after 2.1 before we add any more anyway, so we could just wait for feedback instead.

Fixes #11010

Approach is:
* Throw by default if a converter is associated with a property that will use value generation
* However, a value generator to use can be specified:
  * On the property
  * On the type mapping
  * On a converter
* A client-side generator is added to the Guid converters so that Guid key scenarios still work
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants