Build using Arcade #14177
Merged
Build using Arcade #14177
+4,628
−102,170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
bricelam
force-pushed
the
arcade
branch
6 times, most recently
from
fc40a85 to
789dc1f
Compare
bricelam
commented
Dec 18, 2018
| # | ||
| variables: | ||
| - name: _BuildConfig | ||
| value: Release |
There was a problem hiding this comment.
Should we build both Debug and Release?
|
(Sorting out the official build using an internal branch.) |
natemcmaster
approved these changes
Dec 18, 2018
This comment has been minimized.
This comment has been minimized.
bricelam
commented
Dec 18, 2018
smitpatel
reviewed
Dec 18, 2018
smitpatel
reviewed
Dec 18, 2018
This comment has been minimized.
This comment has been minimized.
natemcmaster
approved these changes
Dec 18, 2018
bricelam
force-pushed
the
arcade
branch
2 times, most recently
from
702ee4e to
7d5bd05
Compare
|
Success! (Internal CI passed) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
|
@bricelam I'm taking a look on the powershell signing issues. |
|
Thanks! I've been trying to repro it locally |
|
@bricelam , turns out this is a bug in SignTool. I've a PR to fix that in progress here: dotnet/arcade#1634 |
Notes for Muggles: - `build` only compiles by default. Add `-test` to run tests and `-pack` to get nupkgs - Dependency versions are now in `eng/Versions.props` - No more API Check, *.baselines.json, or *.breakingchanges.json - No more NuGet package verifier - Nightly builds are now published to https://dotnetfeed.blob.core.windows.net/dotnet-core/index.json Fixes #12537, resolves #14025, resolves dotnet/arcade#1051, resolves dotnet/arcade#1052, resolves dotnet/arcade#1053, resolves dotnet/arcade#1054
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Muggles:
buildcompiles,restorejust initializes the repo,testruns tests. Adding-packproduces nupkgseng/Versions.propsFixes #12537, resolves #14025, resolves dotnet/arcade#1051, resolves dotnet/arcade#1052, resolves dotnet/arcade#1053, resolves dotnet/arcade#1054