Various small miscellaneous fixes #15435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ajcvickers
commented
Apr 21, 2019
ajcvickers
commented
- Fixes BoolToStringConverter should not check if falseValue or trueValue is empty #15294 - BoolToStringConverter should not check if falseValue or trueValue is empty
- Fixes Small typo in resource file #15266 - Small typo in resource file
- Fixes XML comments for DbContext.Attach unclear #14037 - XML comments for DbContext.Attach unclear
- Fixes DbSet.Local does not automatically call DetectChanges #14001 - DbSet.Local does not automatically call DetectChanges
- Fixes WithExtension suggests that 'this' is updated, as well as returning 'this' #13210 - WithExtension suggests that 'this' is updated, as well as returning 'this'
ajcvickers
force-pushed
the
LadyShaver0421
branch
from
16326bd to
5bc852f
Compare
ajcvickers
requested review from
bricelam,
AndriySvyryd,
maumar,
roji and
smitpatel
bricelam
approved these changes
Apr 22, 2019
ajcvickers
force-pushed
the
LadyShaver0421
branch
from
5bc852f to
f284ff7
Compare
* Fixes #15294 - BoolToStringConverter should not check if falseValue or trueValue is empty * Fixes #15266 - Small typo in resource file * Fixes #14037 - XML comments for DbContext.Attach unclear * Fixes #14001 - DbSet.Local does not automatically call DetectChanges * Fixes #13210 - WithExtension suggests that 'this' is updated, as well as returning 'this'
ajcvickers
force-pushed
the
LadyShaver0421
branch
from
f284ff7 to
241f9bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.