Support C# 8 nullable reference types #15499
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces two new conventions - mirroring the existing RequiredPropertyAttributeConvention and RequiredNavigationAttributeConvention - which detect C# 8 non-nullable properties and treat them in the same way as
[Required]
. Some remarks:[Required]
somewhere isn't the same as not defining a property nullable with a question mark.RequiredNavigationAttributeConvention
did not ignore collection properties, so if a collection navigation with[Required]
had an inverse navigation with[Required]
as well, RequiredAttributeOnBothNavigations would be logged. The test RequiredAttribute_does_not_set_is_required_for_collection_navigation seems to have had the navigations switched around, so I changed that (hopefully I haven't misunderstood).Closes #10347
Replaces #14983