Use Microsoft.NET.Compilers #15731
Use Microsoft.NET.Compilers #15731
Conversation
| @@ -1,11 +1,12 @@ | |||
| <Project> | |||
| <PropertyGroup> | |||
| <MSBuildAllProjects>$(MSBuildAllProjects);$(MSBuildThisFileFullPath)</MSBuildAllProjects> | |||
There was a problem hiding this comment.
Pro-tip: MSBuild 16+ does this automagically now :) dotnet/msbuild#1299
There was a problem hiding this comment.
Hmm, do we have a Web SDK issue to stop setting $(MSBuildAllProjects) and something similar for other MSBuild files we ship?
There was a problem hiding this comment.
Haven't looked. I believe dotnet/sdk cleaned all these usages up, so we should probably do the same in the websdk.
| @@ -1,11 +1,12 @@ | |||
| <Project> | |||
| <PropertyGroup> | |||
| <MSBuildAllProjects>$(MSBuildAllProjects);$(MSBuildThisFileFullPath)</MSBuildAllProjects> | |||
There was a problem hiding this comment.
Hmm, do we have a Web SDK issue to stop setting $(MSBuildAllProjects) and something similar for other MSBuild files we ship?
| </PropertyGroup> | ||
| <PropertyGroup Label="Arcade settings"> | ||
| <!-- Opt-in to using the version of the Roslyn compiler bundled with Arcade. --> | ||
| <UsingToolMicrosoftNetCompilers>true</UsingToolMicrosoftNetCompilers> |
There was a problem hiding this comment.
Will this light up in VS?
There was a problem hiding this comment.
Yes. This overrides the version of the compiler bundled with VS and dotnet.exe
This upgrades the compiler to the version bundled in Arcade, which is 3.2.0-beta1-19253-08 right now. This allows this repo to consume a compiler that is newer than what is bundled in the .NET Core SDK. This is valuable during previews to get the latest C# 8 features and test them against EF's expression tree -> SQL code.
This should workaround aspnet/AspNetCore-Internal#2476.