Query: Caching: Added test coverage for more parameterization scenarios.... #1589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…os. Fixed corresponding bugs.
ghost
added
the
| @@ -1238,7 +1441,7 @@ public override void String_StartsWith_MethodCall() | |||
| Assert.Equal( | |||
| @"SELECT [c].[Address], [c].[City], [c].[CompanyName], [c].[ContactName], [c].[ContactTitle], [c].[Country], [c].[CustomerID], [c].[Fax], [c].[Phone], [c].[PostalCode], [c].[Region] | |||
| FROM [Customers] AS [c] | |||
| WHERE [c].[ContactName] LIKE 'M' + '%'", | |||
| WHERE [c].[ContactName] LIKE @__LocalMethod1_0 + '%'", | |||
There was a problem hiding this comment.
Can't remember if we talked about this already but these should use escaping, e.g. in case the value is something like "_m".
There was a problem hiding this comment.
I had already filed this as #474.
|
|
|
|
||
| return true; | ||
| } | ||
| if (fieldInfo != null) |
There was a problem hiding this comment.
@anpete thanks for making this immune to https://entityframework.codeplex.com/workitem/1108 😄
There was a problem hiding this comment.
I'm not sure that does what you think :-) But I know how to make it do what you suggest...
There was a problem hiding this comment.
Do'h, you are right, I was thinking @object should not be null. I was also thinking you can just fallback to the lambda compilation to fail with the right exception. Want me to file a bug? 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... Fixed corresponding bugs.