Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Debug build break #16001

Merged
merged 1 commit into from
Jun 8, 2019
Merged

Fix Debug build break #16001

merged 1 commit into from
Jun 8, 2019

Conversation

ajcvickers
Copy link
Contributor

See #16000

AndriySvyryd
AndriySvyryd requested changes Jun 8, 2019
View reviewed changes
Copy link
Member

@AndriySvyryd AndriySvyryd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead change InMemoryDatabaseTest.cs:189 to return modelBuilder.Model.FinalizeModel();

@ajcvickers
Copy link
Contributor Author

@AndriySvyryd Did you test this in a build? Other tests are also failing.

@AndriySvyryd
Copy link
Member

Works on my machine

@AndriySvyryd
Copy link
Member

Seems that these failures aren't reported in VS 16.1.2 Test Explorer

@ajcvickers
Copy link
Contributor Author

Debug.Asserts are not handled well by XUnit runners.

@ajcvickers ajcvickers merged commit 73cfb39 into master Jun 8, 2019
@ghost ghost deleted the EatingOffTheTable0607 branch June 8, 2019 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndriySvyryd AndriySvyryd AndriySvyryd requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajcvickers @AndriySvyryd