Cosmos: Implement query pipeline #16138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
commented
Jun 18, 2019
| @@ -1284,7 +1284,7 @@ public override async Task Where_bool_member_equals_constant(bool isAsync) | |||
| AssertSql( | |||
| @"SELECT c | |||
| FROM root c | |||
| WHERE (c[""Discriminator""] = ""Product"")"); | |||
| WHERE ((c[""Discriminator""] = ""Product"") AND (c[""Discontinued""] = true))"); | |||
smitpatel
force-pushed
the
smit/cosmosquery
branch
from
88fadd2
to
359b29d
Compare
|
This is ready for review. Others can also review if interested. We are translating a lot more Sql to server now. |
src/EFCore.Cosmos/Query/Pipeline/CosmosQueryableMethodTranslatingExpressionVisitor.cs
Show resolved
Hide resolved
src/EFCore.Cosmos/Query/Pipeline/CosmosShapedQueryCompilingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Cosmos/Query/Pipeline/CosmosSqlTranslatingExpressionVisitor.cs
Show resolved
Hide resolved
src/EFCore.Cosmos/Query/Pipeline/CosmosSqlTranslatingExpressionVisitor.cs
Show resolved
Hide resolved
| { | ||
| IsDistinct = true; | ||
|
|
||
| ClearOrdering(); |
There was a problem hiding this comment.
Why do we need to clear orderings?
There was a problem hiding this comment.
Distinct contract does not specify if inner orderings will be preserved. (e.g. if you use HashSet to compute distinct values). Hence we clear orderings when applying Distinct. It has been in place since long time in relational so I just carried over.
| @@ -179,6 +179,7 @@ public override int GetHashCode() | |||
| var hash = new HashCode(); | |||
| hash.Add(base.GetHashCode()); | |||
| hash.Add(FunctionName); | |||
| hash.Add(IsNiladic); | |||
AndriySvyryd
approved these changes
Jun 19, 2019
smitpatel
force-pushed
the
smit/cosmosquery
branch
from
359b29d
to
3dbe96e
Compare
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.