Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to #15264 - QueryRewrite: incorporate query filters into nav rewrite #16327

Closed
wants to merge 1 commit into from
Closed

Fix to #15264 - QueryRewrite: incorporate query filters into nav rewrite #16327

wants to merge 1 commit into from

Commits on Jun 28, 2019

  1. Fix to #15264 - QueryRewrite: incorporate query filters into nav rewrite 

    Also, fix to #13361 - Query: QueryFilters/Defining queries are not applied recursively

When nav rewrite constructs new EntityQueryable it now looks into EntityType for any query filter annotations and applies them on top. Those predicates are parameterized and the parameters created are injected into the context as part of query execution expression.

Query filters also fundamentally change how nav expansion creates new navigations - before navigations were being added one by one, so we could easily build the NavigationTree by a new node representing given INavigation.
With query filters, the newly created navigation may contain arbitrarily complex NavigationTree structure already (if the query filter itself has some navigations).
To support that, when we create new EntityQueryable for join or collection navigation, we need to visit it (creating NavigationExpansionExpression) and merge the resulting NavigationTree with the previous navigation tree.
    @maumar
    maumar committed Jun 28, 2019
    Configuration menu
    Copy the full SHA
    594b6ec View commit details
    Browse the repository at this point in the history