Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable some more tests #16437

Merged
merged 1 commit into from
Jul 3, 2019
Merged

Re-enable some more tests #16437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/EFCore.Relational/Properties/RelationalStrings.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions src/EFCore.Relational/Properties/RelationalStrings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,9 +250,6 @@
<value>Possible unintended use of a potentially throwing aggregate method (Min, Max, Average) in a subquery. Client evaluation will be used and operator will throw if no data exists. Changing the subquery result type to a nullable type will allow full translation.</value>
<comment>Warning RelationalEventId.QueryPossibleExceptionWithAggregateOperatorWarning</comment>
</data>
<data name="StoredProcedureIncludeNotSupported" xml:space="preserve">
<value>The Include operation is not supported when calling a stored procedure.</value>
</data>
<data name="LogGeneratingDown" xml:space="preserve">
<value>Generating down script for migration '{migration}'.</value>
<comment>Debug RelationalEventId.MigrationGeneratingDownScript string</comment>
Expand Down
4 changes: 2 additions & 2 deletions test/EFCore.CrossStore.FunctionalTests/ConfigurationPatternsTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ public SomeService(MultipleProvidersContext context)
[SqlServerConfiguredCondition]
public class NestedContextDifferentStores
{
[ConditionalFact(Skip = "Tasklist#22")]
[ConditionalFact]
public async Task Can_use_one_context_nested_inside_another_of_a_different_type()
{
using (SqlServerTestStore.GetNorthwindStore())
Expand All @@ -252,7 +252,7 @@ await NestedContextTest(
}
}

[ConditionalFact(Skip = "Tasklist#22")]
[ConditionalFact]
public async Task Can_use_one_context_nested_inside_another_of_a_different_type_with_implicit_services()
{
using (SqlServerTestStore.GetNorthwindStore())
Expand Down
2 changes: 1 addition & 1 deletion test/EFCore.Relational.Specification.Tests/PropertyEntryTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public abstract class PropertyEntryTestBase<TFixture> : IClassFixture<TFixture>

protected TFixture Fixture { get; }

[ConditionalFact(Skip = "issue #15285")]
[ConditionalFact]
public virtual void Property_entry_original_value_is_set()
{
using (var c = CreateF1Context())
Expand Down
159 changes: 0 additions & 159 deletions test/EFCore.Relational.Specification.Tests/Query/AsyncFromSqlSprocQueryTestBase.cs
View file
Open in desktop

This file was deleted.

Loading