Further merge query types into entity types #17101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stubbing out parts of #14537 as an implementation detail. |
bricelam
commented
Aug 12, 2019
| }; | ||
| var table = type == "table" | ||
| ? new DatabaseTable() | ||
| : new DatabaseView(); |
test/EFCore.Design.Tests/Migrations/ModelSnapshotSqlServerTest.cs
Outdated
Show resolved
Hide resolved
AndriySvyryd
approved these changes
Aug 12, 2019
|
As per #17044 (review) We should consider changing the condition in |
|
@AndriySvyryd fixed that, and the duplicate table name validation |
|
|
bricelam
commented
Aug 13, 2019
| @@ -30,7 +30,8 @@ protected override void OnModelCreating(ModelBuilder modelBuilder, DbContext con | |||
| modelBuilder.Entity<Lilt>().Property(e => e.SugarGrams).HasColumnName("SugarGrams"); | |||
| modelBuilder.Entity<Tea>().Property(e => e.CaffeineGrams).HasColumnName("CaffeineGrams"); | |||
|
|
|||
| modelBuilder.Entity<AnimalQuery>().HasNoKey().ToTable("Animal"); | |||
| modelBuilder.Entity<AnimalQuery>().HasNoKey().ToQuery( | |||
| () => context.Set<AnimalQuery>().FromSqlRaw("SELECT * FROM Animal")); | |||
There was a problem hiding this comment.
(We now include keyless entity types when validating that two unrelated entity types don't map to the same table.)
Changes: - Un-obsolete ToView - Differentiate between views and keyless tables in RevEng - Ignore ToView and ToQuery in Migrations; handle HasNoKey - Handle duplicate table names when HasNoKey
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Resolves #14787, fixes #14195