Public API changes to QueryMethodProvider #17153
Conversation
ghost
deleted the
| => methodInfo.IsGenericMethod | ||
| && AverageWithSelectorMethods.Values.Contains(methodInfo.GetGenericMethodDefinition()); | ||
|
|
||
| public static IReadOnlyDictionary<Type, MethodInfo> SumWithoutSelectorMethods { get; } |
There was a problem hiding this comment.
Didn't we decide to expose method to get method info for particular type rather than whole dictionary?
There was a problem hiding this comment.
Yes--I missed this in my review. @roji?
There was a problem hiding this comment.
Oh, sorry, I thought we said changing to read-only is enough - there could conceivable be some value in allowing users to iterate over the keys/values. But I can of course change this if you guys prefer a get method (GetSumWithoutSelector?)
There was a problem hiding this comment.
I don't feel strongly about it.
There was a problem hiding this comment.
Convert to method which takes type. Current usages does not require iterating over values. We could add dictionary later if situation requires it.
No description provided.