Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Support for constant/parameter appearing in Group By key #17186

Merged
merged 1 commit into from
Aug 16, 2019
Merged

Query: Support for constant/parameter appearing in Group By key #17186

merged 1 commit into from
Aug 16, 2019
+201 −743

Commits on Aug 16, 2019

  1. Query: Support for constant/parameter appearing in Group By key 

    Constant/Parameter can be put in projection even if not appearing in grouping key in SQL.
So now we avoid putting Constant/parameter in GROUP BY clause but treat it as normal in other places.
When generating grouping key, wrap convert node to match types in initialization expression (as SQL tree ignores type nullability)
Also merged leftover async group by async tests in single version.

Resolves #14152
Resovles #16844
    @smitpatel
    smitpatel committed Aug 16, 2019
    Configuration menu
    Copy the full SHA
    8b45af3 View commit details
    Browse the repository at this point in the history