Fix some Cosmos discriminator issues #17876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
force-pushed
the
CosmosDiscriminator
branch
from
f44ba0d to
550939c
Compare
smitpatel
reviewed
Sep 17, 2019
| @@ -197,8 +197,8 @@ dotnet_naming_rule.interface_naming.symbols = interface_symbol | |||
| dotnet_naming_rule.interface_naming.style = interface_style | |||
| dotnet_naming_rule.interface_naming.severity = suggestion | |||
|
|
|||
| # Classes, Structs, Enums, Properties, Methods, Events, Namespaces | |||
| dotnet_naming_symbols.class_symbol.applicable_kinds = class, struct, enum, property, method, event, namespace | |||
| # Classes, Structs, Enums, Properties, Methods, Local Functions, Events, Namespaces | |||
smitpatel
approved these changes
Sep 17, 2019
|
As discussed on email, in @Pilchie 's absence I believe we are approved to take this, as 3.1 is in M2 approval mode. I will review it with him when he returns. |
AndriySvyryd
force-pushed
the
CosmosDiscriminator
branch
3 times, most recently
from
460e347 to
718700c
Compare
AndriySvyryd
force-pushed
the
CosmosDiscriminator
branch
from
718700c to
ea29615
Compare
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Don't add discriminators for embedded entities
Allow to update entities without discriminators
Don't try to add the default discriminator if a conflicting property already exists
Fixes #17764
Fixes #17302
Fixes #17814
Customer impact
Several basic scenarios involving discriminators will be unblocked now.
Regression
N/A, 3.0 will be the first RTM release for the Cosmos provider
Risk
Low