Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Expand navigations in Selector/Include in one pass #18625

Merged
merged 1 commit into from
Oct 30, 2019
Merged

Query: Expand navigations in Selector/Include in one pass #18625

merged 1 commit into from
Oct 30, 2019

Commits on Oct 29, 2019

  1. Query: Expand navigations in Selector/Include in one pass 

    Issue: Earlier we expanded navigation in selector and include in separate phase. This causes issue because if the latter visitor expands a reference navigation then former visitor's collection expansions have incorrect references.
Fix: Fix is to make include expansion part of selector expansion as next phase. So by the time we apply include, the correlation predicate in collection hasn't been converted to actual reference. So when it gets converted, it takes correct reference.

Also apply pending selector inside lambda expression since it is a subquery. This caused issue when subquery has a projection which has navigation to expand, which we never visited.

Resolves #18127
Resolves #18090
Resolves #17852
Resolves #17756
    @smitpatel
    smitpatel committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    4619924 View commit details
    Browse the repository at this point in the history