ContainsTranslator fix for arbitrary ICollection<T> implementations #18634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
approved these changes
Oct 29, 2019
|
/cc @Pilchie |
smitpatel
reviewed
Oct 30, 2019
| @@ -1300,6 +1300,28 @@ public override async Task Contains_with_constant_list_value_type_id(bool isAsyn | |||
| WHERE ((c[""Discriminator""] = ""Order"") AND (c[""OrderID""] = 10248))"); | |||
| } | |||
|
|
|||
| [ConditionalTheory(Skip = "Issue#17246 (Contains not implemented)")] | |||
| public override async Task List_Contains_with_parameter_HashSet(bool isAsync) | |||
There was a problem hiding this comment.
Cosmos has ContainsTranslator too. Not sure if it works or why these all tests are disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17342