Support non-static members in C# generation #18655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
approved these changes
Oct 30, 2019
|
@roji Makes sense since it supports providers. Can you file an EF Core issue just so we have something to track it in 3.1. |
roji
force-pushed
the
InstanceMembersInCSharpGeneration
branch
from
d780776
to
b56b02d
Compare
|
Thanks! Opened #18665 to track. |
bricelam
approved these changes
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary to unblock some code literal generation for Npgsql.
As this is a design-only low-risk tiny change, I'm hoping we can get this into 3.1.
/cc @bricelam @Pilchie @ajcvickers