Support Contains on byte arrays on SqlServer #19071
Conversation
| @@ -116,6 +116,10 @@ public override async Task Select_datetimeoffset_comparison_in_projection(bool a | |||
| FROM ""Missions"" AS ""m"""); | |||
| } | |||
|
|
|||
| public override Task Byte_array_contains_literal(bool async) => null; | |||
|
|
|||
| public override Task Byte_array_contains_parameter(bool async) => null; | |||
There was a problem hiding this comment.
Sqlite does have INSTR which works great for literal, but I couldn't find a way to cast/convert a non-literal byte into an Sqlite BLOB. Maybe @bricelam knows?
There was a problem hiding this comment.
SELECT *
FROM Squads
WHERE instr(Banner, char(@someByte)) > 0There was a problem hiding this comment.
Technically, that converts Banner to TEXT, but the result is the same. cast(char(@someByte) as blob) would keep them both blob.
Note, without char(), someByte is converted from integer to blob which results in an 8-byte blob.
roji
force-pushed
the
ByteArrayContains
branch
from
94c0091 to
801e485
Compare
test/EFCore.Specification.Tests/TestModels/GearsOfWarModel/GearsOfWarData.cs
Show resolved
Hide resolved
test/EFCore.SqlServer.FunctionalTests/Query/GearsOfWarQuerySqlServerTest.cs
Outdated
Show resolved
Hide resolved
src/EFCore.SqlServer/Query/Internal/SqlServerMethodCallTranslatorProvider.cs
Outdated
Show resolved
Hide resolved
Resolves #4601
roji
force-pushed
the
ByteArrayContains
branch
from
801e485 to
cf470a0
Compare
roji
changed the title
| && method.GetGenericMethodDefinition().Equals(EnumerableMethods.Contains) | ||
| && arguments[0].Type == typeof(byte[])) | ||
| { | ||
| instance = arguments[0]; |
There was a problem hiding this comment.
Don't assign to instance. Using parameters of a function to store local variable causes confusion.
There was a problem hiding this comment.
It may be even more confusing to have a two instance variables, one "bad" and one "good".
There was a problem hiding this comment.
Don't call it instance. Just call it firstArgument.
Resolves #4601