Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional refactoring of Null Semantics #19168

Merged
merged 1 commit into from
Jan 8, 2020
Merged

Commits on Jan 8, 2020

  1. Additional refactoring of Null Semantics:

    - moving NullSemantics visitor after 2nd level cache - we need to know the parameter values to properly handle IN expressions wrt null semantics,
    - NullSemantics visitor needs to go before SqlExpressionOptimizer and SearchCondition, so those two are also moved after 2nd level cache,
    - combining NullSemantics with SqlExpressionOptimizer (kept SqlExpressionOptimizer name) - SearchCondition now applies some relevant optimization itself, so that we don't need to run full optimizer afterwards,
    - merging InExpressionValuesExpandingExpressionVisitor into SqlExpressionOptimizer as well, so that we don't apply the rewrite for UseRelationalNulls,
    - preventing NulSemantics from performing double visitation when computing non-nullable columns.
    
    Resolves #11464
    Resolves #15722
    Resolves #18338
    Resolves #18597
    Resolves #18689
    Resolves #19019
    maumar committed Jan 8, 2020
    Configuration menu
    Copy the full SHA
    a5f3e26 View commit details
    Browse the repository at this point in the history