Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scaffold empty C# array literals correctly #19408

Merged
merged 1 commit into from
Dec 27, 2019
Merged

Scaffold empty C# array literals correctly #19408

merged 1 commit into from
Dec 27, 2019

Conversation

ajcvickers
Copy link
Member

Fixes #14006

ralmsdeveloper
ralmsdeveloper reviewed Dec 27, 2019
View reviewed changes
src/EFCore.Design/Design/Internal/CSharpHelper.cs

if (vertical)
var first = true;
foreach (var value in valuesList)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajcvickers thinks it would be a good use:

foreach (var value in valuesList [1 ..])

One less if

@ajcvickers ajcvickers merged commit 5b8b8e2 into master Dec 27, 2019
@ajcvickers ajcvickers deleted the HummusForChristmas1226 branch December 27, 2019 22:56
@ajcvickers ajcvickers mentioned this pull request Jan 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralmsdeveloper ralmsdeveloper ralmsdeveloper left review comments

@bricelam bricelam bricelam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty C# array literals are generated incorrectly
3 participants
@ajcvickers @bricelam @ralmsdeveloper