-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cosmos: translate string Contains, StartsWith, and EndsWith #19563
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
81 changes: 81 additions & 0 deletions
81
src/EFCore.Cosmos/Query/Internal/StringMethodTranslator.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| // Copyright (c) .NET Foundation. All rights reserved. | ||
| // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. | ||
|
|
||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Reflection; | ||
| using JetBrains.Annotations; | ||
| using Microsoft.EntityFrameworkCore.Utilities; | ||
|
|
||
| namespace Microsoft.EntityFrameworkCore.Cosmos.Query.Internal | ||
| { | ||
| /// <summary> | ||
| /// This is an internal API that supports the Entity Framework Core infrastructure and not subject to | ||
| /// the same compatibility standards as public APIs. It may be changed or removed without notice in | ||
| /// any release. You should only use it directly in your code with extreme caution and knowing that | ||
| /// doing so can result in application failures when updating to a new Entity Framework Core release. | ||
| /// </summary> | ||
| public class StringMethodTranslator : IMethodCallTranslator | ||
| { | ||
| private static readonly MethodInfo _containsMethodInfo | ||
| = typeof(string).GetRuntimeMethod(nameof(string.Contains), new[] { typeof(string) }); | ||
|
|
||
| private static readonly MethodInfo _startsWithMethodInfo | ||
| = typeof(string).GetRuntimeMethod(nameof(string.StartsWith), new[] { typeof(string) }); | ||
|
|
||
| private static readonly MethodInfo _endsWithMethodInfo | ||
| = typeof(string).GetRuntimeMethod(nameof(string.EndsWith), new[] { typeof(string) }); | ||
|
|
||
| private readonly ISqlExpressionFactory _sqlExpressionFactory; | ||
|
|
||
| /// <summary> | ||
| /// This is an internal API that supports the Entity Framework Core infrastructure and not subject to | ||
| /// the same compatibility standards as public APIs. It may be changed or removed without notice in | ||
| /// any release. You should only use it directly in your code with extreme caution and knowing that | ||
| /// doing so can result in application failures when updating to a new Entity Framework Core release. | ||
| /// </summary> | ||
| public StringMethodTranslator([NotNull] ISqlExpressionFactory sqlExpressionFactory) | ||
| { | ||
| _sqlExpressionFactory = sqlExpressionFactory; | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// This is an internal API that supports the Entity Framework Core infrastructure and not subject to | ||
| /// the same compatibility standards as public APIs. It may be changed or removed without notice in | ||
| /// any release. You should only use it directly in your code with extreme caution and knowing that | ||
| /// doing so can result in application failures when updating to a new Entity Framework Core release. | ||
| /// </summary> | ||
| public virtual SqlExpression Translate(SqlExpression instance, MethodInfo method, IReadOnlyList<SqlExpression> arguments) | ||
| { | ||
| Check.NotNull(method, nameof(method)); | ||
| Check.NotNull(arguments, nameof(arguments)); | ||
|
|
||
| if (_containsMethodInfo.Equals(method)) | ||
| { | ||
| return TranslateSystemFunction("CONTAINS", instance, arguments[0], typeof(bool)); | ||
| } | ||
|
|
||
| if (_startsWithMethodInfo.Equals(method)) | ||
| { | ||
| return TranslateSystemFunction("STARTSWITH", instance, arguments[0], typeof(bool)); | ||
| } | ||
|
|
||
| if (_endsWithMethodInfo.Equals(method)) | ||
| { | ||
| return TranslateSystemFunction("ENDSWITH", instance, arguments[0], typeof(bool)); | ||
| } | ||
|
|
||
| return null; | ||
| } | ||
|
|
||
| private SqlExpression TranslateSystemFunction(string function, SqlExpression instance, SqlExpression pattern, Type returnType) | ||
| { | ||
| Check.NotNull(instance, nameof(instance)); | ||
| return _sqlExpressionFactory.ApplyDefaultTypeMapping( | ||
| _sqlExpressionFactory.Function( | ||
| function, | ||
| new[] { instance, pattern }, | ||
| returnType)); | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ApplyDefaultTypeMapping shouldn't be required. If it does not apply default at later stage automatically then there is bug somewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Can a different issue be opened for that? It may be a test validation issue - it is an error along the lines of "SqlExpression without TypeMapping found in query" and the test fails.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filed #19567