Query: Convert List.Count to Queryable.Count() only for queryables #19831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
force-pushed
the
smit/issue19715
branch
from
47be35d
to
63bbef1
Compare
roji
approved these changes
Feb 7, 2020
| @@ -576,6 +576,17 @@ public virtual void Collection_property_as_scalar_Any() | |||
| .Message.Replace("\r", "").Replace("\n", "")); | |||
| } | |||
|
|
|||
| [ConditionalFact] | |||
| public virtual void Collection_property_as_scalar_Count_member() | |||
There was a problem hiding this comment.
Consider adding a comment on the Npgsql case on this test for context?
For collection scalar property preserve Count member as is. Resolves #19715
smitpatel
force-pushed
the
smit/issue19715
branch
from
63bbef1
to
0479a1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For collection scalar property preserve Count member as is.
Resolves #19715
@roji - Can you verify with this fix it correctly translates in npgsql?