[release/3.1] Query: Expand navigations together in OrderBy/ThenBy #19863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ajcvickers Shouldn't we be adding quirk mode for this an other patch fixes? |
|
@AndriySvyryd Yes! Thanks for remembering that. @dotnet/efcore As @AndriySvyryd says, let's quirk all 3.1 patches as we were previously doing for 2.1. I know it's a pain and often we think it's pointless, but it's exactly because we don't know when it is going to be needed that we should do it for all. |
ajcvickers
approved these changes
Feb 11, 2020
|
@smitpatel Approved by Tactics and branches are open; let's try to get this merged today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18904
Description
Using navigations in OrderBy & ThenBy creates invalid tree which fails during translation.
Customer Impact
Query fails to translate to server throwing exception
How found
Reported by multiple customers.
Test coverage
We did not have test coverage for specific scenario where OrderBy & ThenBy both are expanding new navigations. Add regression test.
Regression?
Regression from 2.1 release
Risk
Low. Affects only processing of OrderBy/ThenBy in query. Basic case of which are covered by many tests.
Also, fix is on by default, but quirk switch is present to revert back to old behavior.