-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for 19799. Allow override of connection string for scaffolding. #19913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bricelam
reviewed
Feb 13, 2020
…CodeGen to override the connection string.
lajones
commented
Feb 14, 2020
src/EFCore.Design/Metadata/Internal/ScaffoldingModelExtensions.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Feb 14, 2020
src/EFCore.Design/Scaffolding/Internal/CSharpDbContextGenerator.cs
Outdated
Show resolved
Hide resolved
lajones
commented
Feb 14, 2020
test/EFCore.Design.Tests/Scaffolding/Internal/ReverseEngineerScaffolderTest.cs
Outdated
Show resolved
Hide resolved
bricelam
suggested changes
Feb 15, 2020
src/EFCore.Design/Scaffolding/Internal/CSharpDbContextGenerator.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Design/Metadata/Internal/ScaffoldingModelExtensions.cs
Outdated
Show resolved
Hide resolved
bricelam
approved these changes
Feb 19, 2020
smitpatel
approved these changes
Feb 19, 2020
Please squash the commits before merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #19799. @bricelam was this what you had in mind?