Allow navigations to owned types to be non-virtual #20015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
previously approved these changes
Feb 21, 2020
lajones
changed the title
smitpatel
reviewed
Feb 21, 2020
|
@ajcvickers @AndriySvyryd @smitpatel Note: with the commits above the scenario in #19847 works even if the collection is virtual. Also I've added some tests including some to test non-proxy lazy-loading. |
smitpatel
dismissed stale reviews from AndriySvyryd and themself
Pending design meeting
lajones
commented
Feb 22, 2020
|
@smitpatel @AndriySvyryd Reverted to original method of doing this as agreed. Please sign-off on that. |
AndriySvyryd
approved these changes
Feb 26, 2020
|
Pinging @smitpatel Any comments or is this what you were expecting? |
smitpatel
approved these changes
Feb 27, 2020
|
What is the planned release for this - would love to see this in 3.1.4 as there is no work-around... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #12462. Also a workaround for #19847 - which could now be solved by making the reference to the owned type non-virtual.
Added some tests.