-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query: Add support for queryable functions #20053
Conversation
68d183a
to
f7b521c
Compare
cc: @pmiddleton |
/// Checks whether the given expression can be evaluated. | ||
/// </summary> | ||
/// <param name="expression"> The expression. </param> | ||
/// <param name="model"> The model. </param> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra whitespace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do cleanup when I submit query changes PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think I have ability to make changes on this PR anymore since the source is now based from a branch in the main repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll make the metadata changes that I had requested previously.
Oh heck if you wanted something screwed up with git you should have called me. I'm the master of that! |
f7b521c
to
bc8e7b1
Compare
@smitpatel Careful. First you move closer to the dark side with the dark theme. Then you start messing up git. Then you even claim to have fixed it "like a boss." If you're not careful the dark side will draw you in. And then you become a manager. |
bc8e7b1
to
bc79c82
Compare
Part of #20051