#16712 create resource strings for exception messages #20087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Muppets
force-pushed
the
#16712-Create-resource-strings-for-exception-messages
branch
2 times, most recently
from
19c3bb8
to
51f09aa
Compare
|
Don't think these failures are from my changes but happy to take another pass if it is. |
|
@Muppets - Just rebase on latest master. There was a commit which was causing that error. I have reverted that commit so master should now be reliably passing. |
Muppets
force-pushed
the
#16712-Create-resource-strings-for-exception-messages
branch
from
51f09aa
to
e826e27
Compare
ajcvickers
approved these changes
Mar 2, 2020
|
@Muppets Thanks for taking on this task. Very much appreciated. :-) |
Muppets
deleted the
#16712-Create-resource-strings-for-exception-messages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes
Caught some of the exceptions in #18923, they should be covered now.
Fixes #16712