Fix API consistency errors in metadata #20267
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more Metadatada API consistency tests
Refactor ApiConsistencyTest
Consistency errors fixed:
bool fromDataAnnotation = false
parameter onIConvention*
Get*ConfigurationSource()
method onIConvention*
CanSet*()
method onIConvention*Builder
"Has", "HasNo", "To", "Is"
. Metadata API can only be prefixed by"Add", "Remove", "Get", "Is"
IModel
andIMutable*
methodsSet*
methods onIMutable*
types should return void and onIConvention*
should return the configured valueRemove*
methods onIMutable*
andIConvention*
type should return the removed valueFixes #17360
Fixes #20269