-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Microsoft.Data.Sqlite: Test against e_sqlcipher and winsqlite3 #20301
Conversation
test/Microsoft.Data.Sqlite.Tests/Microsoft.Data.Sqlite.winsqlite3.Tests.csproj
Show resolved
Hide resolved
Nuts; ordering issue. The Helix SDK is not extensible at all. |
@ajcvickers It looks like we're not compatible with the version of winsqlite3.dll on Helix. |
Errors:
|
I'm trying to find info on what version of SQLite is included in what version of Windows... Looks like we need SQLite 3.16.0 or higher. |
Here is all the images. https://helix.dot.net/ Couldn't find specific Sqlite version. |
|
We could use a different windows queue for winsqlite3 testing. |
I'm just going to skip the tests if the version is too low |
@ajcvickers Are you OK saying the minimum supported version of SQLite is 3.16.0? Alternatively, we could update SqliteDataReader.GetSchemaTable() to be compatible with lower versions. |
@bricelam Yes. Especially as we have a way to bring your own DLL. |
No description provided.