Disallow setting custom translation for DbFunction mapped to TVFs #20315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Even if having a custom translation is less useful it's still valid in some scenarios. So instead of just throwing this should be a warning that defaults to throwing. |
|
Or we can do that when we introduce a better API to set the translation. |
AndriySvyryd
approved these changes
Mar 17, 2020
|
We don't use custom translation in query. (We cannot use it either till API is changed). So throwing is better than warning and then ignoring it. |
|
Please avoid merging more than 2 PRs per 30 minutes to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #20163