Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct Sequential GUID generation #20528

Closed
wants to merge 13 commits into from
Closed

Correct Sequential GUID generation #20528

wants to merge 13 commits into from

Commits on Apr 4, 2020

  1. Add test to show the expectation fails

    @peroyhav
    peroyhav committed Apr 4, 2020
    Configuration menu
    Copy the full SHA
    bd623b4 View commit details
    Browse the repository at this point in the history

  2. Change SequentialGuidValueGenerator implementation to pass all tests.

    @peroyhav
    peroyhav committed Apr 4, 2020
    Configuration menu
    Copy the full SHA
    9310311 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2020

  1. Add check to validate whether the correct version and variant bits ar… 

    …e correctly set for all values of the GUID.
    @peroyhav
    peroyhav committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    c3173b3 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2020

  1. Alter tests to have correlation with MS SQL server generated values.

    @peroyhav
    peroyhav committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    387e1d9 View commit details
    Browse the repository at this point in the history

  2. Change SequentialGuidValueGenerator: Moved data to static variables a… 

    …nd implemented static instantiation, All current tests pass again.

Missing test for validation of _nodeId generation.
    @peroyhav
    peroyhav committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    cac4553 View commit details
    Browse the repository at this point in the history

  3. Add test to ensure the correct variant.

    @peroyhav
    peroyhav committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    b3acc6d View commit details
    Browse the repository at this point in the history

  4. Fix missing vriant bit in _nodeId.

    @peroyhav
    peroyhav committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    9a360e4 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2020

  1. Replace type names with var where possible.

    @peroyhav
    peroyhav committed Apr 13, 2020
    Configuration menu
    Copy the full SHA
    f9ef51e View commit details
    Browse the repository at this point in the history

  2. Fixed missing vars

    @peroyhav
    peroyhav committed Apr 13, 2020
    Configuration menu
    Copy the full SHA
    7254330 View commit details
    Browse the repository at this point in the history

  3. Change test ov value EA11 to validate UUID version number in stead.

    @peroyhav
    peroyhav committed Apr 13, 2020
    Configuration menu
    Copy the full SHA
    cf8be91 View commit details
    Browse the repository at this point in the history

  4. Change UUID value generation to use seed with correct tick count from… 

    … RFC4122 and set version bits accordingly.
    @peroyhav
    peroyhav committed Apr 13, 2020
    Configuration menu
    Copy the full SHA
    1ca35a3 View commit details
    Browse the repository at this point in the history

  5. Add MemoryBarrier to gain better concurrency.

    @peroyhav
    peroyhav committed Apr 13, 2020
    Configuration menu
    Copy the full SHA
    71a6be5 View commit details
    Browse the repository at this point in the history

  6. Correct to get UTC time and not local time.

    @peroyhav
    peroyhav committed Apr 13, 2020
    Configuration menu
    Copy the full SHA
    181f38f View commit details
    Browse the repository at this point in the history